Open devoncarew opened 1 month ago
Based on package usage on pub.dev and a presubmit in google3, I think a reasonable path forward would be to:
equalsDart
function and publish a new package versionequalsDart
and EqualsDart
(this PR) and publish a new major versionequalsDart
one in-line something like https://github.com/dart-lang/code_builder/pull/457/files#diff-a069bad576c5b11a048b0992ff9e46d3861f179d3b2a5c5be71215de051210a6 into their projects (i.e., we no longer publish that matcher)
Creating as a draft PR - I'm trying to determine what would be impacted by this change.
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.