search

dart-lang / core

This repository is home to core Dart packages.
https://pub.dev/publishers/dart.dev
BSD 3-Clause "New" or "Revised" License
13 stars 4 forks source link

Does not compile with dartdevc with implicit-casts: false #436

Closed alextekartik closed 6 years ago

alextekartik commented 6 years ago

I have a project (https://github.com/tekartik/sembast.dart) that does not compile with dartdevc if implicit-casts: false is set (in my project!)

Error compiling dartdevc module:logging|lib/lib__logging.js

[error] The argument type 'dynamic' can't be assigned to the parameter type 'String'. (package:logging/logging.dart, line 186, col 21)

Please fix all errors before compiling (warnings are okay).

The failing test: https://travis-ci.org/tekartik/sembast.dart/jobs/347553963

If I remove implicit-casts in my project, it compiles fine. Strong mode support needed?

alextekartik commented 6 years ago

It seems this package has not been published since 2016! although i had many updates since

pq commented 6 years ago

This should be fixed in 0.11.3+2? Please re-open if not!

alextekartik commented 6 years ago

thanks the test itself is no longer relevant (pub build not used anymore) but i no longer have the issue (cannot tell since when) using logging with either dartdevc or dart2js

pq commented 6 years ago

Great. Thanks for following up!