dart-lang / csslib

A library for parsing CSS.
https://pub.dev/packages/csslib
BSD 3-Clause "New" or "Revised" License
95 stars 38 forks source link

feat: support the `@counter-style` directive #184

Closed sno2 closed 6 days ago

sno2 commented 1 year ago

Implements the @counter-style directive per the spec.


Contribution guidelines:

(note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback)

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

devoncarew commented 1 year ago

Thanks for the contribution! Adding @leonsenft for thoughts.

@sno2 - please also bump the pubspec version to match (and the version there and in the chaneglog should likely be 0.17.4-wip).

mosuem commented 6 days ago

Closing as the dart-lang/csslib repository is merged into the dart-lang/tools monorepo. Please re-open this PR there!