Closed cpswan closed 1 year ago
Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:
https://dart-review.googlesource.com/c/dart-docker/+/291160
Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.
Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:
https://dart-review.googlesource.com/c/dart-docker/+/291161
Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.
https://dart-review.googlesource.com/c/dart-docker/+/291161 has been updated with the latest commits from this pull request.
https://dart-review.googlesource.com/c/dart-docker/+/291161 has been updated with the latest commits from this pull request.
Having tested build images based on this, I'm removing the draft status. It's ready to go when the other pieces slide into place.
Opened #141 to flag what might be a RISC-V specific issue found as a result of that testing.
https://dart-review.googlesource.com/c/dart-docker/+/291161 has been updated with the latest commits from this pull request.
Comment on Gerrit:
Hi Chris, thanks for sending this PR!
We discussed a bit, and we'd like to wait with merging this until RISC-V is supported in our stable channel. I hope that is OK.
Of course that's OK @athomas
As I noted above there are a bunch of upstream dependencies that need to stabilise. There's a slim chance that will happen before RISC-V gets into stable channel, but my expectation is that RISC-V will be in Dart stable before it's in Debian stable.
@athomas - is there any issue we can link to to track when this PR can move forward?
Closing as both the corresponding gerrit CLs have been closed. Please feel free to re-contribute (based on feedback from @athomas).
This will help towards #96, though there are a bunch of things that need to be resolved first, so making this a draft for now:
debian:bullseye-slim
(Stable) doesn't support RISC-V. There's support indebian:unstable-slim
(Sid), but that's way off for now as there's not even a release date for the presenttesting
build Bookworm.