search

dart-lang / dart-docker

Docker images for the Dart programming language (https://dart.dev)
BSD 3-Clause "New" or "Revised" License
67 stars 15 forks source link

Bump actions/checkout from 3.5.0 to 3.5.2 #146

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps actions/checkout from 3.5.0 to 3.5.2.

Release notes

Sourced from actions/checkout's releases.

v3.5.2

What's Changed

Full Changelog: https://github.com/actions/checkout/compare/v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

Full Changelog: https://github.com/actions/checkout/compare/v3.5.0...v3.5.1

Changelog

Sourced from actions/checkout's changelog.

Changelog

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

v3.0.1

v3.0.0

v2.3.1

v2.3.0

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
copybara-service[bot] commented 1 year ago

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/dart-docker/+/300300

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

copybara-service[bot] commented 1 year ago

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/dart-docker/+/300301

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

devoncarew commented 1 year ago

Ah, this was one of the ones that we shouldn't merge manually...

sortie commented 1 year ago

@devoncarew I broke the emergency glass to bypass mandatory code review and manually merged github back to googlesource in df82c627d84f22503d701ca2663a2c49f15d9ffe. Yeah it's easy to make this mistake as an org admin. At least these days we have the copybara gerrit comments above. You will see those if and only if the changelist must not be merged on github, so that's a useful sanity check to memorize and double check :)

sortie commented 1 year ago

If you're able to filter incoming pull request notifications, you could also stop monitoring homebrew-dart and dart-docker. I'm automatically notified about any incoming gerrit changelists on those repositories and handle them when they pop up :)

devoncarew commented 1 year ago

You will see those if and only if the changelist must not be merged on github

Yes, those are helpful. In this case I was reviewing several dozen open PRs from dependabot and didn't read the PR comments closely.

I may contribute a workflow which will prevent PR submission (ala https://github.com/dart-lang/webdev/blob/master/.github/workflows/do_not_submit.yml).

sortie commented 1 year ago

Oh that would be super cool! Tell me more about this do not submit :D