search

dart-lang / dart-pad

An online Dart editor with support for console, web, and Flutter apps
https://dartpad.dev
BSD 3-Clause "New" or "Revised" License
1.69k stars 549 forks source link

The "flash"/"hint"/"test results" popup CSS seems to be incorrect #1754

Closed theacodes closed 3 years ago

theacodes commented 3 years ago

What happened?

This looks weird! 👽

Screen Shot 2021-02-11 at 3 18 33 PM

Steps to reproduce problem

Head over to https://dart.dev/codelabs/dart-cheatsheet#using-this-in-a-constructor and hit "hint" on any of the embedded Dart Pads. This also appears when you "solve" the challenge and Dart Pad notifies you.

Additional info

Browser

I reproduced this in both Chrome (88.0.4324.146) and Safari (Version 14.0.3 (15610.4.3.1.6, 15610)).

Machine

Operating system: macOS

Version: 10.15.7

parlough commented 3 years ago

I believe this was due to my changes moving away from Octicons, I'll take a look.

Thanks for pointing this out! I thought this situation worked fine...oops

theacodes commented 3 years ago

CSS is an ancient evil that lashes out at the slightest provocation. No apologies necessary!

I'm happy to be the reviewer on the change. :)

On Thu, Feb 11, 2021 at 3:46 PM Parker Lougheed notifications@github.com wrote:

I believe this was due to my changes moving away from Octicons, I'll take a look.

Thanks for pointing this out! I thought this situation worked fine...oops

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dart-lang/dart-pad/issues/1754#issuecomment-777778498, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB5I43XELY7W5SWRQR25GTS6Q62PANCNFSM4XPQJXJA .