search

dart-lang / dart-syntax-highlight

Tools and documentation for how Dart code is formatted
BSD 3-Clause "New" or "Revised" License
22 stars 11 forks source link

Enable Windows bot #59

Closed DanTup closed 7 months ago

DanTup commented 7 months ago

See https://github.com/dart-lang/dart-syntax-highlight/pull/58.. The tests were failing in weird ways if you have autocrlf=true because the code didn't handle \r\n properly.

I have a fix, but I want to see if the Windows bots use autocrlf=true as extra validation (and ongoing testing once that fix lands) so that contributors using autocrlf=true don't hit these kinds of issues.

DanTup commented 7 months ago

Bot seems stuck, but fixing this another way that just runs with both line endings always - https://github.com/dart-lang/dart-syntax-highlight/pull/60