search

dart-lang / dart_ci

Tools used by Dart's continuous integration (CI) testing that aren't needed by Dart SDK contributors. Mirrored from dart.googlesource.com/dart_ci. Do not land pull requests on Github.
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

Add Contributors documentation to projects, and consider switching to GitHub reviews from Gerrit #127

Open whesse opened 2 years ago

whesse commented 2 years ago

To encourage contributions from other authors, either instructions for how to create Gerrit CLs for changes should be added, or the repository could be switched to use GitHub reviews.

As @devoncarew suggested when suggesting changes with a PR: "If PR won't work here, I can recreate this work as a gerrit CL. However, it would be nice to either take PRs, or, add some brief contributing instructions to the repo to describe how to author changes.

You might consider flipping the system of record for the codebase, as that would allow us to do things like use github actions to validate the code."

devoncarew commented 2 years ago

consider switching to GitHub reviews from Gerrit

One things that would be possible - if this repo moves closer to using github as the system of record - is to auto-deploy the app to firebase when changes land on master. We've set that up on one other Flutter web + firebase app in the dart-lang/ org; I can provide pointers if that's interesting.