search

dart-lang / dart_ci

Tools used by Dart's continuous integration (CI) testing that aren't needed by Dart SDK contributors. Mirrored from dart.googlesource.com/dart_ci. Do not land pull requests on Github.
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

No scroll bar #143

Open rakudrama opened 1 year ago

rakudrama commented 1 year ago

There is no scroll bar for the filtered results, which makes queries with many results (e.g. dart2js) unusable. It would also be useful to have a count of results for tracking progress fixing tests.

whesse commented 1 year ago

I'm unclear on which application and which view there is no scroll bar. If this is the current_results main results page, there is a vertical scrollbar which only appears while scrolling or hovering over the right side of the page - this is standard flutter behavior.

The count of results, broken up into passing, failing, and flaky, and by test name or by (test name, configuration) pair is at the bottom of the results page, in colored pills.

The results can also be fetched directly from the server, using the json link, but you may need to support fetching multiple pages.

rakudrama commented 1 year ago

I see the counts now.

I do not see a scroll-bar no matter what I do. PgUp and PgDn don't do anything either, even if I click on the window.

I sometimes see rendering artifacts like the red smear below.

I am using Chrome remote desktop into a Linux machine running the Cinnamon window manager.

If I visit the site directly from my chromebook, I do see the transient scroll bar. It is extremely janky on the dataset below. PgUp and PgDn still do not work.

image

/cc @yjbanov

whesse commented 11 months ago

The jankiness of the scroll bar is due to having a long list of variable size items, which has poor performance due to https://github.com/flutter/flutter/issues/52207 .

I will file an issue to fix this by making the list entries constant-height, and expanding the test result details into an overlay or a side/top panely. Filing a separate issue for that refactoring.

The other effects may be due to this list performance problem, so I'd like to look at them again after the performance fix lands.