dart-lang / dart_ci

Tools used by Dart's continuous integration (CI) testing that aren't needed by Dart SDK contributors. Mirrored from dart.googlesource.com/dart_ci. Do not land pull requests on Github.
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

Approval messages in current results feed are not connected to test but to commit range? #149

Open dcharkes opened 1 year ago

dcharkes commented 1 year ago

When going to the history of a test, all kinds of comments show up that are not related to that test but to other test status approvals that happened to be in the same commit range.

My hunch is that when a range of commits has multiple test failures, and then someone goes in and approves with comment each test failure individually, the comments are not tied to the specific test status change, but to the commit range. And that when showing a test history, all the comments on the commit range are shown for each commit range that has status changes for that test.

This makes it harder to reapprove tests that are meta-flaking, as there are a bunch of different referenced issues in the test history instead of just one.

Example: https://dart-ci.web.app/#showLatestFailures=false&test=co19/LibTest/io/WebSocket/closeCode_A01_t02&configurations=vm-win-release-ia32

Screenshot 2023-07-06 at 09 28 11
dcharkes commented 1 year ago

Also, when doing another approval on the same commit range, it shows the message of the previous approval.

Screenshot 2023-07-06 at 09 36 08