search

dart-lang / dart_ci

Tools used by Dart's continuous integration (CI) testing that aren't needed by Dart SDK contributors. Mirrored from dart.googlesource.com/dart_ci. Do not land pull requests on Github.
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

symbolize on command line requires undocumented quotes around the "keywords*" args (like `arm64 release force ios`) #161

Open jmagman opened 5 months ago

jmagman commented 5 months ago

bin/symbolize.dart <input-file|URI> 'keywords*' requires quotes around the keywords.
https://github.com/dart-lang/dart_ci/tree/main/github-label-notifier/symbolizer#binsymbolizedart

For example:

$ dart pub global run symbolizer:symbolize https://github.com/flutter/flutter/issues/126463#issue-1704536896 flutter#v3.7.11 arm64 release force ios

does not work and shows the help test because there are more than 2 args https://github.com/dart-lang/dart_ci/blob/510788efa644955fca3baba715ac04200be653ad/github-label-notifier/symbolizer/bin/symbolize.dart#L56

However, with quotes, this does work:

$ dart pub global run symbolizer:symbolize https://github.com/flutter/flutter/issues/126463#issue-1704536896 "flutter#v3.7.11 arm64 release force ios"

Ideally the extra keywords would be cli options and flags so users don't need to make a single last argument and know how that's formatted.

At a minimum, the help text in this scenario should be giving a hint where the quotes are needed.

cc @mraleph