search

dart-lang / dart_ci

Tools used by Dart's continuous integration (CI) testing that aren't needed by Dart SDK contributors. Mirrored from dart.googlesource.com/dart_ci. Do not land pull requests on Github.
BSD 3-Clause "New" or "Revised" License
18 stars 5 forks source link

minor suggestion: tweak to the link in gerrit UI #83

Open sigmundch opened 4 years ago

sigmundch commented 4 years ago

I'm not sure how configurable is the link "Aggregated test results" that appears in the gerrit UI. Could it be different depending on some data?

If so, it would be great if we could include more data on the link text itself (like how many test changed, which patchset are we referring to). For example, "Aggregated test results: 17 tests failing in patchset 2", or "Aggregated test results: 10 tests now passing in patchset 4", or simply "Aggregated test results: no test changes".

The goal is mainly to help us discover whether it is worth it for us to check the link in more detail.

athomas commented 4 years ago

It's possible, but would make the plugin a bit more complicated. I would prefer to have some sort of iframed compact view in the panel below the title rather than expanding the link (that way it would be the results feed owning the UI rather than the Gerrit plugin).