Tools used by Dart's continuous integration (CI) testing that aren't needed by Dart SDK contributors. Mirrored from dart.googlesource.com/dart_ci. Do not land pull requests on Github.
BSD 3-Clause "New" or "Revised" License
18
stars
5
forks
source link
When results from a new builder are processed, add a comment to the commit where they appear #92
When an entirely new builder appears, the results of the first build don't have a blamelist, because they are all new results not compared to anything in the past. Their blamelist is therefore just the single commit that the build executed on.
We want to add a comment to that commit, saying that the new configuration showing up with new results isn't due to that commit, but is just new in general.
Do this by calling a function that adds a new comment from line 89 of dart_ci/functions/node/builder.dart.
The function needs to be added to firestore_impl.dart and firestore.dart, and can be modeled on the existing functions in the class and on the code at dart_ci/results_feed/lib/src/services/firestore_service.dart:155. The approved, results, try_results, and review fields can be omitted.
When an entirely new builder appears, the results of the first build don't have a blamelist, because they are all new results not compared to anything in the past. Their blamelist is therefore just the single commit that the build executed on.
We want to add a comment to that commit, saying that the new configuration showing up with new results isn't due to that commit, but is just new in general.
Do this by calling a function that adds a new comment from line 89 of dart_ci/functions/node/builder.dart. The function needs to be added to firestore_impl.dart and firestore.dart, and can be modeled on the existing functions in the class and on the code at dart_ci/results_feed/lib/src/services/firestore_service.dart:155. The approved, results, try_results, and review fields can be omitted.