search

dart-lang / dart_style

An opinionated formatter/linter for Dart code
https://pub.dev/packages/dart_style
BSD 3-Clause "New" or "Revised" License
646 stars 121 forks source link

Make the language version parameter to DartFormatter mandatory. #1563

Closed munificent closed 1 month ago

munificent commented 1 month ago

This is a breaking change, so bumping the major version of dart_style, the first time I've done that since the null safety migration (!).

munificent commented 1 month ago

Yeah, I'm expecting that this means dart_style can't be rolled into google3 for a while until we're ready for it. If you'd like, I can set up a "3.0" branch and land the changes there so that the main branch remains in a state where we can land bug fixes and roll into google3 if you think it's worth it.

My thinking was to just go ahead and land directly on main. Then if it turns out we do need to land some bug fixes without the 3.0 changes, I can always just branch off a previous commit at that point in time.

natebosch commented 1 month ago

My thinking was to just go ahead and land directly on main. Then if it turns out we do need to land some bug fixes without the 3.0 changes, I can always just branch off a previous commit at that point in time.

Landing and delaying the roll until we're ready SGTM.