search

dart-lang / ecosystem

This repository is home to general Dart Ecosystem tools and packages.
BSD 3-Clause "New" or "Revised" License
47 stars 7 forks source link

cosmetic update to the triager's comment format #273

Closed devoncarew closed 5 months ago

devoncarew commented 5 months ago
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
devoncarew commented 5 months ago

This changes the comment from:

https://github.com/dart-lang/sdk/issues/56051#issuecomment-2179291036

to:

Summary: The covariant_instance_field_test fails when inlining is disabled, causing a runtime error where a late covariant field is assigned a value of the wrong type. This issue may be related to the experimental linker changes made to Shorebird.

github-actions[bot] commented 5 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: |

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :heavy_check_mark:

Details | File | Coverage | | :--- | :--- | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR).

API leaks :heavy_check_mark:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- |

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:dart_flutter_team_lints | 3.1.0 | already published at pub.dev | | package:firehose | 0.9.0 | already published at pub.dev | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.