search

dart-lang / ecosystem

This repository is home to general Dart Ecosystem tools and packages.
BSD 3-Clause "New" or "Revised" License
47 stars 7 forks source link

Remove the use-flutter configuration #284

Open natebosch opened 3 months ago

natebosch commented 3 months ago

Always set up the flutter SDK and use flutter pub publish, even for non-flutter Dart packages. The flutter command can publish non-flutter packages so no behavior changes are expected during the publish action.

Directly remove the argument, configuration, and all references immediately. There is no plan for a deprecation/migration phase since this only impacts CI, and the fix is trivial.

github-actions[bot] commented 3 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |firehose|Breaking|0.9.1|0.10.0|0.10.0|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :heavy_check_mark:

Details | File | Coverage | | :--- | :--- | |pkgs/firehose/lib/firehose.dart| :green_heart: 35 % | |pkgs/firehose/lib/src/health/health.dart| :green_heart: 94 % | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR).

API leaks :heavy_check_mark:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- |

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:firehose | 0.10.0 | **ready to publish** | | package:dart_flutter_team_lints | 3.1.1-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
github-actions[bot] commented 3 months ago

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.10.0 ready to publish firehose-v0.10.0
package:dart_flutter_team_lints 3.1.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

natebosch commented 3 months ago 
  flutter pub publish --dry-run
  ProcessException: No such file or directory
    Command: flutter pub publish --dry-run

I think I broke the ignore_packages argument somehow?

natebosch commented 3 months ago

Oh, now I see what's happening.

This PR make firehose our first package that is not a flutter package, but requires flutter at runtime for the tests. We can't make it a real flutter package because that will break compatibility with dart pub global activate.

@kevmoo - we still don't have a general "add extra setup actions" feature in mono_repo do we?

kevmoo commented 3 months ago

@natebosch – I don't think so. It's been soooo long

mosuem commented 3 months ago

@natebosch did you test this by flipping some repo using auto-publishing and PR health checks to use-flutter: true? That would be a good smoke test, before shipping this to all users.