dart-lang / ecosystem

This repository is home to general Dart Ecosystem tools and packages.
BSD 3-Clause "New" or "Revised" License
47 stars 7 forks source link

add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment #285

Closed devoncarew closed 3 months ago

devoncarew commented 3 months ago

The idea behind this revision is to use the above two lints for a period of time ourselves (these lints are likely going out with the next major revision of package:lints - see https://github.com/orgs/dart-lang/projects/73).


Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
github-actions[bot] commented 3 months ago

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.2.0 ready to publish dart_flutter_team_lints-v3.2.0
package:firehose 0.9.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions[bot] commented 3 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |dart_flutter_team_lints|Breaking|3.1.1-wip|3.2.0|3.2.0|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :heavy_check_mark:

Details | File | Coverage | | :--- | :--- | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR).

API leaks :heavy_check_mark:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- |

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:dart_flutter_team_lints | 3.2.0 | **ready to publish** | | package:firehose | 0.9.1 | already published at pub.dev | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
kevmoo commented 3 months ago

Should we add library_name here, too?

parlough commented 3 months ago

Should we add library_name here, too?

I guess you mean unnecessary_library_name? If not publishing a -dev release of lints with it for this package to depend on, I'd say it's a good idea :)

kevmoo commented 3 months ago

@parlough – yes, that's what i mean – @devoncarew ?

parlough commented 3 months ago

Ah the set already has unnecessary_library_name actually :)

https://github.com/dart-lang/ecosystem/blob/f977423b1d9faa2afb34b805e9f28de0b2a657f1/pkgs/dart_flutter_team_lints/lib/analysis_options.yaml#L37

devoncarew commented 3 months ago

Yup, already added unnecessary_library_name recently. Landing and will publish this now.