dart-lang / fake_async

Fake asynchronous events for deterministic testing.
https://pub.dev/packages/fake_async
Apache License 2.0
90 stars 16 forks source link

Change of Copyright notice #49

Closed julia410m closed 2 years ago

julia410m commented 2 years ago

Hello! According to the Appendix of Apache License 2.0, if you want to license your software under this License you should "attach the boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information". This condition is not met now. Please add a copyright notice in the appropriate form, including the year of the software development and your name and surname. Thank you in advance

Copyright [yyyy] [name of copyright owner]

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

devoncarew commented 2 years ago

Hi - thanks for the inquiry here. I believe this is working as intended however - that section is indicating that file headers should use the above template, w/ the placeholders replaced with content specific to that project; see for example https://github.com/dart-lang/fake_async/blob/master/lib/fake_async.dart.

julia410m commented 2 years ago

@devoncarew I agree with you about the form of the LICENSE file, it shouldn't be changed of course. I also see that all your files that contain code have the above mentioned copyright notice.

I have already opened the same issue with another developer about another software under the Apache 2.0 License.

As I said there, we use your software and would like to assemble a file like this one that requires the component name, version, and copyright.

The copyright notices may be somewhat different (for instance, the development year) in the files. Maybe it is worth to assemble the NOTICE file, according to the APPENDIX of the Apache 2.0 License "and consider also including a NOTICE file that references the License". The instruction for the NOTICE file assembling is here. It seems that it will be possible to add in this file the common copyright notice which will cover all files of this software.

julia410m commented 2 years ago

@devoncarew hi. What do you think about the above mentioned suggestion?

devoncarew commented 1 year ago

I guess I don't feel strongly about having a NOTICE file? We don't have one for most (all?) of our Apache repos. If it contained the same license as in the LICENSE file and the same copyright as in the headers of the source files, I suppose it wouldn't hurt to have one.

If you'd like to contribute one we'd likely accept the PR.

natebosch commented 1 year ago

According to the Appendix of Apache License 2.0, if you want to license your software under this License you should

The appendix says

and consider also including a NOTICE file that references the License

I'm not eager to track down and republish any apache licensed packages for something that we should "consider" doing.