search

dart-lang / homebrew-dart

Dart team's official tap for homebrew.
BSD 3-Clause "New" or "Revised" License
155 stars 52 forks source link

MacOS.prefer_64_bit is deprecated. #58

Closed voldemortensen closed 5 years ago

voldemortensen commented 5 years ago

While upgrading dart I received this error: Error: dart-lang/dart/dart: undefined methodprefer_64_bit?' for OS::Mac:Module`

Upon further investigation I found that the prefer_64_bit method has been deprecated. See https://github.com/Homebrew/brew/commit/170c5493a4e3628ed77137215a9ed6328e1a17c8#diff-1c1e64ec9fa3342388d0ddb7a9607eca

The new way to check is the is_64_bit method.

kevmoo commented 5 years ago

CC @whesse @athomas – should be an easy fix

puxlit commented 5 years ago

@voldemortensen, shouldn't that be Hardware::CPU.is_64_bit? instead of MacOS.is_64_bit??

voldemortensen commented 5 years ago

Yes it should. Nice catch!

On Jan 8, 2019, at 21:26, Xiao Di Guan notifications@github.com wrote:

@voldemortensen, shouldn't that be Hardware::CPU.is_64_bit? instead of MacOS.is_64_bit??

r6m commented 5 years ago

Hi, it still gives the error. Isn't it fixed yet?

AlexGHancock commented 5 years ago

Same problem here... Perhaps I should downgrade homebrew to get it working?

kevmoo commented 5 years ago

This is not completely fix yet – Need to update https://github.com/dart-lang/sdk/tree/master/tools/apps/update_homebrew too!

kevmoo commented 5 years ago

Fixed in https://github.com/dart-lang/sdk/commit/8719fb3a7b8e8bf0b0d5df8ef389cd039b1fd6f0

voldemortensen commented 5 years ago

Thanks for the fix!