search

dart-lang / html

Dart port of html5lib. For parsing HTML/HTML5 with Dart. Works in the client and on the server.
https://pub.dev/packages/html
Other
277 stars 59 forks source link

Remove tests expecting >64-bit ints #65

Closed kevmoo closed 6 years ago

kevmoo commented 6 years ago

Fixes https://github.com/dart-lang/tools/issues/1007

kevmoo commented 6 years ago

Zero disagreement here. I was optimizing for moving fast.

Happy to review any such change. :-)

On Fri, Jan 26, 2018 at 12:52 PM, sigmundch notifications@github.com wrote:

@sigmundch commented on this pull request.

In test/data/tokenizer/test4.test https://github.com/dart-lang/html/pull/65#discussion_r164219233:

@@ -152,14 +152,6 @@ "input":"�", "output":["ParseError", ["Character", "\uFFFD"]]},

-{"description":"65-bit hex numeric entity",

  • @jmesserly https://github.com/jmesserly - possibly Jenny has more insights into this, but I thought these tests were purposely covering >64 bit because it is technically a valid part of the html spec.

My guess is that rather than deleting the tests, we should mark them as failing, or create a new bug entry with the 2 tests so coverage can be added again in the future (likely by changing int.parse with BigInt.parse or something similar.)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dart-lang/html/pull/65#pullrequestreview-91965752, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCiuKW1P5ON8oo5QKJNEwU6jNGTNVUks5tOjsAgaJpZM4RlPYx .