search

dart-lang / http

A composable API for making HTTP requests in Dart.
https://pub.dev/packages/http
BSD 3-Clause "New" or "Revised" License
1.03k stars 358 forks source link

Initial publish of `ok_http` and firehose setup #1259

Open brianquinlan opened 4 months ago

brianquinlan commented 4 months ago

@Anikate-De @camsim99

camsim99 commented 4 months ago

@natebosch Hi! @Anikate-De is close to finishing the implementation for ok_http so we will be looking to publish soon. Brian mentioned possibly (me) needing access to the labs publisher which I assume is related to this issue (I am unfamiliar with the publishing process for Dart packages). Is there anything I can do here?

natebosch commented 4 months ago

Since this package hasn't been published, we might need to do the first publish manually. @devoncarew Have we ever used firehose to bootstrap a previously unpublished package? Should we try it and see if it works, or should I publish manually?

I think we can't set up the protected environment for example before the package exists. https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose#publishing-from-a-protected-github-environment

Maybe it's safe to set up the GitHub side and then configure pub after the first publish?

devoncarew commented 4 months ago

I'm not sure it's possible to bootstrap using firehose. I think you have to publish once (manually) then move the package into the target publisher, and use the package admin page to enable publishing-via-github.

I've only lightly used the publishing w/ an environment feature; I don't think it gets us the two-party review thing that we'd want, and adds another step to publishing. I'd recommend just avoiding it unless it adds more than I'm aware of.

natebosch commented 4 months ago

Oh, I must have forgot that this already happened. https://github.com/dart-lang/http/blob/master/.github/workflows/publish.yaml

It looks like firehose doesn't support flutter packages though.

camsim99 commented 4 months ago

It looks like firehose doesn't support flutter packages though.

Oh interesting so after you do the first manual publish, we will have to continue to manually publish for every new version?

natebosch commented 4 months ago

I think I'll just need to split the workflow up into two separate ones for the flutter and non-flutter packages. It looks like firehose has a config option for this.

natebosch commented 4 months ago

Hmm

Message from server: Package name `ok_http` is too similar to another active package: `okhttp` (https://pub.dev/packages/okhttp).

@jonasfj - is there a workaround?

natebosch commented 3 months ago

Pub deployment went through and I was able to publish. https://pub.dev/packages/ok_http/versions/0.1.0

Next step is to split the workflow file into flutter and non-flutter workflows