search

dart-lang / i18n

A general mono-repo for Dart i18n and l10n packages.
BSD 3-Clause "New" or "Revised" License
63 stars 36 forks source link

Type error in `date_symbol_data_http_request` #486

Closed blaugold closed 1 year ago

blaugold commented 1 year ago

Describe the bug

The following error is thrown from initializeDateFormatting when compiled with ddc (e.g. using flutter run --device chrome):

[main] ERROR: Uncaught error when running app Expected a value of type 'Future<List<dynamic>>', but got one of type '_Future<void>'
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 266:49      throw_
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 99:3        castError
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 485:10  cast
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/classes.dart 638:14     as_C
packages/intl/date_symbol_data_http_request.dart 32:47                            <fn>
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 367:37  _checkAndCall
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 372:39  dcall
packages/intl/src/date_format_internal.dart 79:14                                 initializeIndividualLocaleDateFormatting
packages/intl/date_symbol_data_http_request.dart 31:10                            initializeDateFormatting

The following code expects initLocale to return a Future<List<dynamic>>, but LazyLocaleData.initLocale returns Future<void>:

https://github.com/dart-lang/intl/blob/43507e1bcf4d18c04dd7875199cf92010199a18f/lib/date_symbol_data_http_request.dart#L32-L35

When launching the app with flutter run ... --release no exception is thrown.

System info

Dart SDK 2.19.5
Flutter SDK 3.7.8

dependencies:
- ab_testing_core 0.15.0
- async 2.10.0 [collection meta]
- collection 1.17.0
- crypto 3.0.2 [typed_data]
- csv 5.0.1
- firebase_analytics 10.0.6 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_analytics_web 0.5.1+5 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_core 2.3.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine]
- flutter_countdown_timer 4.1.0 [flutter]
- flutter_mobx 2.0.6+4 [flutter mobx]4
- http 0.13.5 [async http_parser meta path]
- intl 0.18.0 [clock meta path]
- js 0.6.5 [meta]
- meta 1.8.0
- mobx 2.1.1 [meta]
- package_info_plus 3.0.1 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32]
- platform 3.1.0
- provider 6.0.4 [collection flutter nested]
- retry 3.1.0
- sentry 6.22.0 [http meta stack_trace uuid intl]
- sentry_flutter 6.22.0 [flutter flutter_web_plugins sentry package_info_plus meta]
- universal_html 2.0.8 [async csslib charcode collection html meta source_span typed_data universal_io]
- url_launcher 6.1.6 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]

dev dependencies:
- analyzer 4.7.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- build_runner 2.3.2 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_gen_runner 4.3.0 [flutter_gen_core build collection crypto glob path]
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]
- lotum_analysis 1.0.1
- mobx_codegen 2.0.7+3 [analyzer build build_resolvers meta mobx path source_gen]
- sentry_dart_plugin 1.0.0-beta.4 [yaml injector ansicolor system_info2 file http crypto convert process]

dependency overrides:
- _flutterfire_internals 1.0.9 [collection firebase_core firebase_core_platform_interface flutter meta]
- firebase_core_web 2.0.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- flutter_gen_core 4.3.0 [path yaml mime xml dartx color collection json_annotation glob dart_style analyzer args pub_semver source_span]
- package_info_plus 3.0.1 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32]

transitive dependencies:
- _fe_analyzer_shared 47.0.0 [meta]
- ansicolor 2.0.1
- args 2.3.1
- audioplayers 4.0.1 [audioplayers_android audioplayers_darwin audioplayers_linux audioplayers_platform_interface audioplayers_web audioplayers_windows file flutter http meta path_provider synchronized uuid]
- audioplayers_android 3.0.1 [audioplayers_platform_interface flutter]
- audioplayers_darwin 4.0.1 [audioplayers_platform_interface flutter]
- audioplayers_linux 2.0.1 [audioplayers_platform_interface flutter]
- audioplayers_platform_interface 5.0.0 [flutter meta plugin_platform_interface]
- audioplayers_web 3.0.1 [audioplayers_platform_interface flutter flutter_web_plugins js]
- audioplayers_windows 2.0.1 [audioplayers_platform_interface flutter]
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.3.1 [analyzer async convert crypto glob logging meta path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.1.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.0.10 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.4.2 [built_collection collection fixnum meta]
- cbl 2.1.8 [cbl_ffi characters collection ffi meta path stream_channel synchronized web_socket_channel]
- cbl_ffi 0.8.1+3 [cbl_libcblite_api cbl_libcblitedart_api ffi meta]
- cbl_flutter 2.0.6 [cbl cbl_flutter_platform_interface flutter path_provider]
- cbl_flutter_ee 2.1.6 [cbl_flutter_platform_interface cbl_libcblite_api cbl_libcblitedart_api flutter]
- cbl_flutter_platform_interface 2.0.6 [cbl flutter plugin_platform_interface]
- cbl_libcblite_api 3.0.11
- cbl_libcblitedart_api 5.0.0
- cbl_sentry 1.0.6 [cbl sentry]
- characters 1.2.1
- charcode 1.3.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- clock 1.1.1
- code_builder 4.3.0 [built_collection built_value collection matcher meta]
- color 3.0.0
- connectivity_plus 2.3.9 [flutter connectivity_plus_platform_interface connectivity_plus_linux connectivity_plus_macos connectivity_plus_web connectivity_plus_windows]
- connectivity_plus_linux 1.3.1 [flutter connectivity_plus_platform_interface meta nm]
- connectivity_plus_macos 1.2.6 [connectivity_plus_platform_interface flutter]
- connectivity_plus_platform_interface 1.2.3 [flutter meta plugin_platform_interface]
- connectivity_plus_web 1.2.5 [connectivity_plus_platform_interface flutter_web_plugins flutter js]
- connectivity_plus_windows 1.2.2 [connectivity_plus_platform_interface flutter]
- convert 3.1.1 [typed_data]
- csslib 0.17.2 [source_span]
- dart_style 2.2.4 [analyzer args path pub_semver source_span]
- dartx 1.1.0 [characters collection crypto meta path time]
- dbus 0.7.8 [args ffi meta xml]
- fading_edge_scrollview 3.0.0 [flutter]
- fake_async 1.3.1 [clock collection]
- ffi 2.0.1
- file 6.1.4 [meta path]
- file_utils 1.0.1 [globbing path]
- firebase_analytics_platform_interface 3.3.14 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_core_platform_interface 4.5.2 [collection flutter flutter_test meta plugin_platform_interface]
- fixnum 1.0.1
- flutter_isolate 2.0.3 [flutter uuid]
- flutter_lottie 0.3.0 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- frontend_server_client 3.1.0 [async path]
- glob 2.1.0 [async collection file path string_scanner]
- globbing 1.0.0 [path]
- graphs 2.2.0 [collection]
- html 0.15.1 [csslib source_span]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- injector 2.0.0
- io 1.0.3 [meta path string_scanner]
- isolate_handler 1.0.2 [flutter flutter_isolate]
- json_annotation 4.7.0 [meta]
- lints 2.0.1
- logging 1.1.0
- matcher 0.12.13 [meta stack_trace]
- material_color_utilities 0.2.0
- mime 1.0.2
- nested 1.0.0 [flutter]
- nm 0.5.0 [dbus]
- package_config 2.1.0 [path]
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- path 1.8.2
- path_provider 2.0.14 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.0.21 [flutter path_provider_platform_interface]
- path_provider_foundation 2.2.2 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.0.5 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.3 [ffi flutter path path_provider_platform_interface win32]
- petitparser 5.1.0 [meta]
- plugin_platform_interface 2.1.3 [meta]
- pool 1.5.1 [async stack_trace]
- process 4.2.4 [file path platform]
- pub_semver 2.1.2 [collection meta]
- pubspec_parse 1.2.1 [checked_yaml collection json_annotation pub_semver yaml]
- shelf 1.4.0 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.3 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.2.6 [analyzer async build dart_style glob meta path source_span yaml]
- source_span 1.9.1 [collection path term_glyph]
- sqflite 2.2.0+3 [flutter sqflite_common path]
- sqflite_common 2.4.0+2 [synchronized path meta]
- stack_trace 1.11.0 [path]
- stream_channel 2.1.1 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- synchronized 3.0.1
- system_info2 2.0.4 [file_utils path]
- tar 0.5.6 [async meta typed_data]
- term_glyph 1.2.1
- test_api 0.4.16 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- time 2.1.3 [clock]
- timezone 0.9.0 [path]
- timing 1.0.0 [json_annotation]
- typed_data 1.3.1 [collection]
- universal_io 2.0.4 [collection crypto meta typed_data]
- url_launcher_android 6.0.21 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.1.1 [flutter plugin_platform_interface]
- url_launcher_web 2.0.13 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.1 [flutter url_launcher_platform_interface]
- uuid 3.0.7 [crypto]
- vector_math 2.1.4
- watcher 1.0.2 [async path]
- web_socket_channel 2.2.0 [async crypto stream_channel]
- win32 3.1.1 [ffi]
- xdg_directories 0.2.0+2 [meta path process]
- xml 6.1.0 [collection meta petitparser]
- yaml 3.1.1 [collection source_span string_scanner]
mosuem commented 1 year ago

Thanks for filing this; could you confirm the PR fixes your issue? I am not sure I can reproduce it fully.

blaugold commented 1 year ago

@mosuem Thanks for the quick response! The PR does fix my issue.