search

dart-lang / i18n

A general mono-repo for Dart i18n and l10n packages.
BSD 3-Clause "New" or "Revised" License
63 stars 36 forks source link

Add list format from ICU4X #810

Closed mosuem closed 6 months ago

mosuem commented 6 months ago

Add list formatting, renaming the js Intl types conjunction and disjunction to the more user friendly ICU4X types and and or.

Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
github-actions[bot] commented 6 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |intl4x|Breaking|0.8.2-wip|0.8.2-wip|0.8.2-wip|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :warning:

Details | File | Coverage | | :--- | :--- | |pkgs/intl4x/build.dart| :broken_heart: Not covered | |pkgs/intl4x/lib/src/list_format/list_format_4x.dart| :green_heart: 100 % | |pkgs/intl4x/lib/src/list_format/list_format_ecma.dart| :green_heart: 100 % | |pkgs/intl4x/lib/src/list_format/list_format_impl.dart| :green_heart: 100 % | |pkgs/intl4x/lib/src/list_format/list_format_options.dart| :green_heart: 14 % | |pkgs/intl4x/lib/src/list_format/list_format_stub_4x.dart| :broken_heart: 0 % :arrow_down: NaN % | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with `skip-coverage-check`

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:intl | 0.20.0-wip | WIP (no publish necessary) | | package:intl4x | 0.8.2-wip | WIP (no publish necessary) | | package:intl_translation | 0.20.0-wip | WIP (no publish necessary) | | package:messages | 0.2.0 | already published at pub.dev | | package:messages_builder | 0.2.1 | already published at pub.dev | | package:messages_serializer | 0.2.1 | already published at pub.dev | | package:messages_shrinker | 0.2.2-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
github-actions[bot] commented 6 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |intl4x|Breaking|0.8.2-wip|0.8.2-wip|0.8.2-wip|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :warning:

Details | File | Coverage | | :--- | :--- | |pkgs/intl4x/lib/src/list_format/list_format_4x.dart| :green_heart: 100 % | |pkgs/intl4x/lib/src/list_format/list_format_ecma.dart| :green_heart: 100 % | |pkgs/intl4x/lib/src/list_format/list_format_impl.dart| :green_heart: 100 % | |pkgs/intl4x/lib/src/list_format/list_format_options.dart| :green_heart: 14 % | |pkgs/intl4x/lib/src/list_format/list_format_stub_4x.dart| :broken_heart: 0 % :arrow_down: NaN % | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with `skip-coverage-check`

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:intl | 0.20.0-wip | WIP (no publish necessary) | | package:intl4x | 0.8.2-wip | WIP (no publish necessary) | | package:intl_translation | 0.20.0-wip | WIP (no publish necessary) | | package:messages | 0.2.0 | already published at pub.dev | | package:messages_builder | 0.2.1 | already published at pub.dev | | package:messages_serializer | 0.2.1 | already published at pub.dev | | package:messages_shrinker | 0.2.2-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.