search

dart-lang / i18n

A general mono-repo for Dart i18n and l10n packages.
BSD 3-Clause "New" or "Revised" License
58 stars 34 forks source link

Prepare intl_translation for release support intl 0.19 #836

Closed parlough closed 1 month ago

parlough commented 1 month ago
github-actions[bot] commented 1 month ago

Package publishing

Package Version Status Publish tag (post-merge)
package:intl_translation 0.20.0 ready to publish intl_translation-v0.20.0
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.8.2 already published at pub.dev
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions[bot] commented 1 month ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |intl_translation|Breaking|0.20.0-wip|0.20.0|0.20.0|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :warning:

Details | File | Coverage | | :--- | :--- | |pkgs/intl_translation/bin/extract_to_arb.dart| :broken_heart: Not covered | |pkgs/intl_translation/bin/generate_from_arb.dart| :broken_heart: Not covered | |pkgs/intl_translation/lib/extract_messages.dart| :green_heart: 52 % | |pkgs/intl_translation/lib/generate_localized.dart| :broken_heart: Not covered | |pkgs/intl_translation/lib/src/message_parser.dart| :green_heart: 99 % | |pkgs/intl_translation/lib/src/messages/message.dart| :green_heart: 87 % | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with `skip-coverage-check`.

API leaks :warning:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- | |intl_translation|MainMessage
Message| This check can be disabled by tagging the PR with `skip-leaking-check`.

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :exclamation:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:intl | 0.20.0-wip | WIP (no publish necessary) | | package:intl4x | 0.8.2 | already published at pub.dev | | package:messages | 0.2.0 | already published at pub.dev | | package:messages_builder | 0.2.1 | already published at pub.dev | | package:messages_serializer | 0.2.1 | already published at pub.dev | | package:messages_shrinker | 0.2.2-wip | WIP (no publish necessary) | | package:intl_translation | 0.20.0 | (error) pubspec version (0.20.0) and changelog (0.20.0-wip) don't agree | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. This check can be disabled by tagging the PR with `skip-version-check`.
github-actions[bot] commented 1 month ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |intl_translation|Breaking|0.20.0-wip|0.20.0|0.20.0|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :warning:

Details | File | Coverage | | :--- | :--- | |pkgs/intl_translation/bin/extract_to_arb.dart| :broken_heart: Not covered | |pkgs/intl_translation/bin/generate_from_arb.dart| :broken_heart: Not covered | |pkgs/intl_translation/lib/extract_messages.dart| :green_heart: 52 % | |pkgs/intl_translation/lib/generate_localized.dart| :broken_heart: Not covered | |pkgs/intl_translation/lib/src/message_parser.dart| :green_heart: 99 % | |pkgs/intl_translation/lib/src/messages/message.dart| :green_heart: 87 % | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with `skip-coverage-check`.

API leaks :warning:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- | |intl_translation|MainMessage
Message| This check can be disabled by tagging the PR with `skip-leaking-check`.

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:intl_translation | 0.20.0 | **ready to publish** | | package:intl | 0.20.0-wip | WIP (no publish necessary) | | package:intl4x | 0.8.2 | already published at pub.dev | | package:messages | 0.2.0 | already published at pub.dev | | package:messages_builder | 0.2.1 | already published at pub.dev | | package:messages_serializer | 0.2.1 | already published at pub.dev | | package:messages_shrinker | 0.2.2-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
devoncarew commented 1 month ago

It looks like the only semantic changes here are moving the dep on package:intl from ^0.18.0 to ^0.19.0, and requiring Dart 3.0.0. I'm a little surprised that this package doesn't yet include 0.19.0 in its dep ranges (i.e., >=0.18.0 <0.20.0).

I believe that the source-of-record for intl_translation is google3. In any case, we should wait for a review from @mosuem before merging and publishing.

devoncarew commented 1 month ago

@parlough - I'm going to land a portion of this internally (https://github.com/dart-lang/i18n/pull/839); that change will be mirrored out to github and we can publish from there.

parlough commented 1 month ago

Sounds great, thanks @devoncarew!

I can revisit the cleanup here separately.