search

dart-lang / i18n

A general mono-repo for Dart i18n and l10n packages.
BSD 3-Clause "New" or "Revised" License
63 stars 36 forks source link

Update package:intl lints dependency to v4 #847

Closed parlough closed 3 months ago

parlough commented 4 months ago

@mosuem I updated the generated files to conform to the lints, could you land this PR internally and perhaps add the generator changes? I appreciate the help!

github-actions[bot] commented 4 months ago

Package publishing

Package Version Status Publish tag (post-merge)
package:intl4x 0.9.0 ready to publish intl4x-v0.9.0
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions[bot] commented 4 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |intl|None|0.20.0-wip|0.20.0-wip|0.20.0-wip|:heavy_check_mark:|

Changelog Entry :heavy_check_mark:

Details | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.

Coverage :warning:

Details | File | Coverage | | :--- | :--- | |pkgs/intl/lib/date_symbol_data_custom.dart| :green_heart: 67 % | |pkgs/intl/lib/date_symbol_data_file.dart| :green_heart: 100 % | |pkgs/intl/lib/date_symbol_data_http_request.dart| :broken_heart: Not covered | |pkgs/intl/lib/date_symbol_data_local.dart| :green_heart: 100 % | |pkgs/intl/lib/date_symbols.dart| :green_heart: 49 % | |pkgs/intl/lib/date_time_patterns.dart| :green_heart: 100 % | |pkgs/intl/lib/intl.dart| :green_heart: 96 % | |pkgs/intl/lib/intl_browser.dart| :green_heart: 100 % | |pkgs/intl/lib/intl_default.dart| :broken_heart: Not covered | |pkgs/intl/lib/intl_standalone.dart| :green_heart: 75 % | |pkgs/intl/lib/locale.dart| :broken_heart: Not covered | |pkgs/intl/lib/message_format.dart| :green_heart: 97 % | |pkgs/intl/lib/message_lookup_by_library.dart| :broken_heart: Not covered | |pkgs/intl/lib/number_symbols.dart| :green_heart: 80 % | |pkgs/intl/lib/number_symbols_data.dart| :green_heart: 100 % | |pkgs/intl/lib/src/date_format_internal.dart| :green_heart: 100 % | |pkgs/intl/lib/src/file_data_reader.dart| :green_heart: 100 % | |pkgs/intl/lib/src/http_request_data_reader.dart| :broken_heart: Not covered | |pkgs/intl/lib/src/intl/bidi.dart| :green_heart: 97 % | |pkgs/intl/lib/src/intl/compact_number_format.dart| :broken_heart: 96 % :arrow_down: 1 % | |pkgs/intl/lib/src/intl/date_format_field.dart| :green_heart: 85 % | |pkgs/intl/lib/src/intl/number_parser.dart| :green_heart: 100 % | |pkgs/intl/lib/src/intl_default.dart| :broken_heart: Not covered | |pkgs/intl/lib/src/intl_helpers.dart| :green_heart: 48 % | |pkgs/intl/lib/src/lazy_locale_data.dart| :green_heart: 78 % | |pkgs/intl/lib/src/plural_rules.dart| :green_heart: 85 % | |pkgs/intl/tool/generate_locale_data_files.dart| :broken_heart: Not covered | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with `skip-coverage-check`.

API leaks :warning:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- | |intl|_DateFormatField
StringStack
DateBuilder| This check can be disabled by tagging the PR with `skip-leaking-check`.

License Headers :heavy_check_mark:

Details ``` // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. ``` | Files | | :--- | | _no missing headers_ | All source files should start with a [license header](https://github.com/dart-lang/ecosystem/wiki/License-Header).

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:intl4x | 0.9.0 | **ready to publish** | | package:intl | 0.20.0-wip | WIP (no publish necessary) | | package:intl_translation | 0.20.1-wip | WIP (no publish necessary) | | package:messages | 0.2.0 | already published at pub.dev | | package:messages_builder | 0.2.1 | already published at pub.dev | | package:messages_serializer | 0.2.1 | already published at pub.dev | | package:messages_shrinker | 0.2.2-wip | WIP (no publish necessary) | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
mosuem commented 3 months ago

@parlough Thanks for the PR! This just needs a changelog entry, then I can approve the PR and it will be imported to g3 and then auto-merged here.