dart-lang / language

Design of the Dart language
Other
2.67k stars 205 forks source link

[parts-with-imports] Consider dropping the library name from the library directive #3969

Open bwilkerson opened 4 months ago

bwilkerson commented 4 months ago

Referring to https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/parts_with_imports.md.

Given that part of directives will be required to use a URI rather than a library name, unless there's somewhere else that a library name can appear, can we consider removing the ability to name libraries?

lrhn commented 4 months ago

Definitely could. It's a breaking change with no real benefit, because library names also do not hurt anything.

It may break code using dart:mirrors, which, IIRC, allows looking up libraries by name.

But I'm game! If that's what we want, this is a reasonable time to do that breaking change, dive we are removing the last language based reason to have a name.

We may want to first add "no library names" lint to the recommended set, have a fix for it, and let that simmer for a while, to have a deprecation window before we remove it. We've had the part of library.name linted against for a while already, so removing it won't be sudden.