bwilkerson
commented
1 year ago The conversion from "always_" => "" works well.
The conversion from "avoid" => "no" seems like we're making a stronger statement than the style guide currently makes, so we might want to try to find something a little less absolute.
The conversion from "prefer" => "use" works well most of the time (like use_single_quotes), but sometimes it doesn't (like use_typing_uninitialized_variables and use_void_to_null). Some of these names will need a bit more work.
It probably isn't worth renaming avoid_as and prefer_bool_in_asserts because they're deprecated, and there's a good chance that they'll be removed before they're renamed.
Similarly, we have discussed deprecating always_require_non_null_named_parameters, avoid_returning_null, avoid_returning_null_for_future, and prefer_equal_for_default_values, so those might or might not be worth renaming.
pq
Following up from #3827, this issue scopes the conversation to removing prescriptive language from lint names. Such a change (in bulk) would affect 88 (or just over 40%) of our 218 rules.
The applied replacements are:
but other ideas are welcome.
Note that this is is very much a proposal and it's not obvious that the benefits would outweigh the churn (even with an automated migration path via
dart fix). Please chime in!always_declare_return_typesdeclare_return_typesalways_put_control_body_on_new_lineput_control_body_on_new_linealways_put_required_named_parameters_firstput_required_named_parameters_firstalways_require_non_null_named_parametersrequire_non_null_named_parametersalways_specify_typesspecify_typesalways_use_package_importsuse_package_importsavoid_annotating_with_dynamicno_annotating_with_dynamicavoid_asno_asavoid_bool_literals_in_conditional_expressionsno_bool_literals_in_conditional_expressionsavoid_catches_without_on_clausesno_catches_without_on_clausesavoid_catching_errorsno_catching_errorsavoid_classes_with_only_static_membersno_classes_with_only_static_membersavoid_double_and_int_checksno_double_and_int_checksavoid_dynamic_callsno_dynamic_callsavoid_empty_elseno_empty_elseavoid_escaping_inner_quotesno_escaping_inner_quotesavoid_field_initializers_in_const_classesno_field_initializers_in_const_classesavoid_final_parametersno_final_parametersavoid_function_literals_in_foreach_callsno_function_literals_in_foreach_callsavoid_implementing_value_typesno_implementing_value_typesavoid_init_to_nullno_init_to_nullavoid_js_rounded_intsno_js_rounded_intsavoid_multiple_declarations_per_lineno_multiple_declarations_per_lineavoid_null_checks_in_equality_operatorsno_null_checks_in_equality_operatorsavoid_equals_and_hash_code_on_mutable_classesno_equals_and_hash_code_on_mutable_classesavoid_positional_boolean_parametersno_positional_boolean_parametersavoid_printno_printavoid_private_typedef_functionsno_private_typedef_functionsavoid_redundant_argument_valuesno_redundant_argument_valuesavoid_relative_lib_importsno_relative_lib_importsavoid_renaming_method_parametersno_renaming_method_parametersavoid_returning_nullno_returning_nullavoid_returning_null_for_futureno_returning_null_for_futureavoid_returning_null_for_voidno_returning_null_for_voidavoid_returning_thisno_returning_thisavoid_return_types_on_settersno_return_types_on_settersavoid_setters_without_gettersno_setters_without_gettersavoid_shadowing_type_parametersno_shadowing_type_parametersavoid_single_cascade_in_expression_statementsno_single_cascade_in_expression_statementsavoid_slow_async_iono_slow_async_ioavoid_type_to_stringno_type_to_stringavoid_types_as_parameter_namesno_types_as_parameter_namesavoid_types_on_closure_parametersno_types_on_closure_parametersavoid_unnecessary_containersno_unnecessary_containersavoid_unused_constructor_parametersno_unused_constructor_parametersavoid_void_asyncno_void_asyncavoid_web_libraries_in_flutterno_web_libraries_in_flutterprefer_adjacent_string_concatenationuse_adjacent_string_concatenationprefer_asserts_in_initializer_listsuse_asserts_in_initializer_listsprefer_asserts_with_messageuse_asserts_with_messageprefer_bool_in_assertsuse_bool_in_assertsprefer_collection_literalsuse_collection_literalsprefer_conditional_assignmentuse_conditional_assignmentprefer_const_constructorsuse_const_constructorsprefer_const_constructors_in_immutablesuse_const_constructors_in_immutablesprefer_const_declarationsuse_const_declarationsprefer_const_literals_to_create_immutablesuse_const_literals_to_create_immutablesprefer_constructors_over_static_methodsuse_constructors_over_static_methodsprefer_containsuse_containsprefer_double_quotesuse_double_quotesprefer_equal_for_default_valuesuse_equal_for_default_valuesprefer_expression_function_bodiesuse_expression_function_bodiesprefer_final_fieldsuse_final_fieldsprefer_final_in_for_eachuse_final_in_for_eachprefer_final_localsuse_final_localsprefer_final_parametersuse_final_parametersprefer_foreachuse_foreachprefer_for_elements_to_map_fromIterableuse_for_elements_to_map_fromIterableprefer_function_declarations_over_variablesuse_function_declarations_over_variablesprefer_generic_function_type_aliasesuse_generic_function_type_aliasesprefer_if_elements_to_conditional_expressionsuse_if_elements_to_conditional_expressionsprefer_if_null_operatorsuse_if_null_operatorsprefer_initializing_formalsuse_initializing_formalsprefer_inlined_addsuse_inlined_addsprefer_interpolation_to_compose_stringsuse_interpolation_to_compose_stringsprefer_int_literalsuse_int_literalsprefer_is_emptyuse_is_emptyprefer_is_not_emptyuse_is_not_emptyprefer_is_not_operatoruse_is_not_operatorprefer_iterable_whereTypeuse_iterable_whereTypeprefer_mixinuse_mixinprefer_null_aware_operatorsuse_null_aware_operatorsprefer_null_aware_method_callsuse_null_aware_method_callsprefer_relative_importsuse_relative_importsprefer_single_quotesuse_single_quotesprefer_spread_collectionsuse_spread_collectionsprefer_typing_uninitialized_variablesuse_typing_uninitialized_variablesprefer_void_to_nulluse_void_to_null