Open pq opened 4 months ago
rrousselGit
commented
4 months ago If this is about running lints on generated code, I assume lots of those probably should not apply.
In particular, all the stylistic ones. For instance avoid_renaming_method_parameters would be a huge pain for macro authors to handle. Or prefer_double_quotes vs prefer_single_quotes doesn't have a finite answer.
pq
commented
4 months ago Thanks @rrousselGit. Partly yes, this is about generated code. We expect most lints to not apply[*] in that case for exactly the reasons you mention.
Slightly more interesting are lints that might apply (in some potentially limited way) to macros and user created augmentation libraries.
*[]* Indeed, we're especially interested in the ones that should* and we don't have a good categorization for those. (Security lints come to mind... Certain error-protecting ones too...) Feedback welcome!
A meta-issue to discuss and track work on linter support for macros.
Existing Lints
Some existing lints will need tests (minimally) and possibly enhanced implementations.
always_put_control_body_on_new_linealways_use_package_importsavoid_bool_literals_in_conditional_expressionsavoid_catches_without_on_clausesavoid_catching_errorsavoid_double_and_int_checksavoid_dynamic_callsavoid_empty_elseavoid_escaping_inner_quotesavoid_final_parametersavoid_function_literals_in_foreach_callsavoid_implementing_value_typesavoid_init_to_nullavoid_js_rounded_intsavoid_multiple_declarations_per_lineavoid_null_checks_in_equality_operatorsavoid_printavoid_redundant_argument_valuesavoid_relative_lib_importsavoid_renaming_method_parametersavoid_return_types_on_settersavoid_returning_null_for_voidavoid_returning_thisavoid_shadowing_type_parametersavoid_single_cascade_in_expression_statementsavoid_slow_async_ioavoid_type_to_stringavoid_types_as_parameter_namesavoid_types_on_closure_parametersavoid_unnecessary_containersavoid_void_asyncavoid_web_libraries_in_flutterawait_only_futurescancel_subscriptionscascade_invocationscast_nullable_to_non_nullableclose_sinkscollection_methods_unrelated_typecombinators_orderingcomment_referencesconditional_uri_does_not_existcontrol_flow_in_finallycurly_braces_in_flow_control_structuresdangling_library_doc_commentsdepend_on_referenced_packagesdeprecated_consistencydeprecated_member_use_from_same_packagediagnostic_describe_all_propertiesdirectives_orderingdiscarded_futuresdo_not_use_environmentempty_catchesempty_constructor_bodiesempty_statementseol_at_end_of_fileerase_dart_type_extension_typesexhaustive_casesfile_namesflutter_style_todosimplementation_importsimplicit_call_tearoffsimplicit_reopeninvalid_case_patternsjoin_return_with_assignmentleading_newlines_in_multiline_stringslibrary_annotationslibrary_nameslibrary_prefixeslibrary_private_types_in_public_apilines_longer_than_80_charsliteral_only_boolean_expressionsmatching_super_parametersmissing_whitespace_between_adjacent_stringsno_adjacent_strings_in_listno_default_casesno_duplicate_case_valuesno_leading_underscores_for_library_prefixesno_leading_underscores_for_local_identifiersno_literal_bool_comparisonsno_logic_in_create_stateno_runtimeType_toStringno_self_assignmentsno_wildcard_variable_usesnoop_primitive_operationsnull_check_on_nullable_type_parameternull_closuresomit_local_variable_typesonly_throw_errorspackage_namespackage_prefixed_library_namesparameter_assignmentsprefer_adjacent_string_concatenationprefer_asserts_in_initializer_listsprefer_asserts_with_messageprefer_collection_literalsprefer_conditional_assignmentprefer_const_declarationsprefer_const_literals_to_create_immutablesprefer_constructors_over_static_methodsprefer_containsprefer_double_quotesprefer_expression_function_bodiesprefer_final_in_for_eachprefer_final_localsprefer_final_parametersprefer_for_elements_to_map_fromIterableprefer_foreachprefer_function_declarations_over_variablesprefer_if_elements_to_conditional_expressionsprefer_if_null_operatorsprefer_initializing_formalsprefer_inlined_addsprefer_int_literalsprefer_interpolation_to_compose_stringsprefer_is_emptyprefer_is_not_emptyprefer_is_not_operatorprefer_iterable_whereTypeprefer_mixinprefer_null_aware_method_callsprefer_null_aware_operatorsprefer_relative_importsprefer_single_quotesprefer_spread_collectionsprovide_deprecation_messagerecursive_gettersrequire_trailing_commassecure_pubspec_urlssized_box_for_whitespacesized_box_shrink_expandslash_for_doc_commentssort_child_properties_lastsort_constructors_firstsort_pub_dependenciessort_unnamed_constructors_firsttest_types_in_equalsthrow_in_finallytighten_type_of_initializing_formalstype_init_formalstype_literal_in_constant_patternunawaited_futuresunnecessary_await_in_returnunnecessary_brace_in_string_interpsunnecessary_breaksunnecessary_constunnecessary_constructor_nameunnecessary_finalunnecessary_lambdasunnecessary_lateunnecessary_library_directiveunnecessary_newunnecessary_null_aware_assignmentsunnecessary_null_aware_operator_on_extension_on_nullableunnecessary_null_checksunnecessary_null_in_if_null_operatorsunnecessary_nullable_for_final_variable_declarationsunnecessary_parenthesisunnecessary_raw_stringsunnecessary_statementsunnecessary_string_escapesunnecessary_string_interpolationsunnecessary_thisunnecessary_to_list_in_spreadsunrelated_type_equality_checksunsafe_htmluse_build_context_synchronouslyuse_colored_boxuse_decorated_boxuse_full_hex_values_for_flutter_colorsuse_function_type_syntax_for_parametersuse_if_null_to_convert_nulls_to_boolsuse_is_even_rather_than_modulouse_key_in_widget_constructorsuse_named_constantsuse_raw_stringsuse_rethrow_when_possibleuse_setters_to_change_propertiesuse_string_buffersuse_string_in_part_of_directivesuse_super_parametersuse_test_throws_matchersuse_to_and_as_if_applicablevalid_regexpsvoid_checksGeneral questions that have implications for a number of lints:
New Lints
Authors and users of macros (and augmentation classes) might benefit from some new lints.
🚧 Feedback welcome! 🚧
Analyzer / Server Support
Visibility
To whom and under what circumstances should we display diagnostics produced in macro generated files?
/fyi @dart-lang/language-team @bwilkerson @keertip @scheglov @srawlins