Removing low-priority lint rules

[srawlins]

If we land analyzer plugins well, we may choose to stop supporting our lowest-priority lint rules. Maybe lint rules that do not guard against errors or bloat, and are not in the lints:core or lints:recommended sets, and are not used by the Dart or Flutter teams or Google, and are not backed by Effective Dart.

If any team or user found any such removed rule useful, they could resurrect it themselves quite easily, as the new plugins API uses the existing API for defining a first-party lint rule.

I thought I'd jot down some ideas to see what the scope of this might be. I personally think we could remove:

• always_put_control_body_on_new_line
• always_specify_types
• avoid_bool_literals_in_conditional_expressions
• avoid_escaping_inner_quotes
• avoid_final_parameters
• avoid_multiple_declarations_per_line
• avoid_private_typedef_functions
• avoid_returning_this
• do_not_use_environment
• eol_at_end_of_file
• flutter_style_todos
• join_return_with_assignment
• library_names
• literal_only_boolean_expressions
• no_literal_bool_comparisons
• one_member_abstracts
• parameter_assignments
• prefer_expression_function_bodies
• prefer_foreach
• prefer_int_literals
• prefer_void_to_null
• unnecessary_raw_strings
• unsafe_html
• use_is_even_rather_than_modulo

[lrhn]

I'd say these ones do avoid bloat:

• avoid_bool_literals_in_conditional_expressions
• no_literal_bool_comparisons

Not a lot of bloat, but still unnecessarily long code.

A little sad for eol_at_end_of_file, but that's something your editor should be doing anyway, so not really lint-worthy. A few of the rest will be "good riddance" from me, but most really don't matter any more. If ever. (SGTM!)

[eernstg]

They look like local syntactic style related rules. Probably not something that anyone would miss a lot.

One exception: always_specify_types seems to be the target of a healthy dose of complaints, but is it really true that nobody cares about that one?

[pq]

I love the idea of a clean up! If we do something like this, it'd be nice to get crisp on criteria for removal. Should it matter if the proposed rules are in broad adoption?