dart-lang / lints

Official Dart lint rules; the core and recommended set of lints suggested by the Dart team.
https://pub.dev/packages/lints
BSD 3-Clause "New" or "Revised" License
118 stars 30 forks source link

Fixes formatting error in the rules.md table #206

Closed lenzpaul closed 2 months ago

lenzpaul commented 2 months ago

The content after the rule invalid_runtime_check_with_js_interop_types was not formatted in a table due to syntax error


google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

devoncarew commented 2 months ago

Thanks for the PR! This file is generated from the lint metadata, so we'd need to update both the generation script (https://github.com/dart-lang/lints/blob/main/tool/gen_docs.dart), and then run it once to produce the new markdown file.

lenzpaul commented 2 months ago

Thanks for the PR! This file is generated from the lint metadata, so we'd need to update both the generation script (https://github.com/dart-lang/lints/blob/main/tool/gen_docs.dart), and then run it once to produce the new markdown file.

Ok thanks! I'll look into updating that file too 🙂

lenzpaul commented 2 months ago

Thanks for the PR! This file is generated from the lint metadata, so we'd need to update both the generation script (https://github.com/dart-lang/lints/blob/main/tool/gen_docs.dart), and then run it once to produce the new markdown file.

I've updated and ran the generation script to generate the corrected output

devoncarew commented 2 months ago

Thanks! That page looks much better now :)

https://github.com/dart-lang/lints/blob/main/rules.md