dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
443 stars 201 forks source link

Optimise TableSyntax #472

Closed chenzhiguang closed 1 year ago

chenzhiguang commented 1 year ago

Now it is 100% conform to GFM table spec.

srawlins commented 1 year ago

How does this contain commits which are already in dart-lang:master? I can't review a PR with commits like this... but I'm honestly not even sure how it's happened. CC @kevmoo, my git expert. What is needed here? A rebase?

chenzhiguang commented 1 year ago

I did a rebase, then it messed up.

kevmoo commented 1 year ago

Yeah, you want to do a git rebase -i – and squash things down

kevmoo commented 1 year ago

@chenzhiguang – I think I fixed it.

@srawlins – PTAL

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3349674559


Files with Coverage Reduction New Missed Lines %
lib/src/block_syntaxes/table_syntax.dart 1 89.66%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 3323865806: 0.004%
Covered Lines: 1210
Relevant Lines: 1274

💛 - Coveralls
chenzhiguang commented 1 year ago

@chenzhiguang – I think I fixed it.

@srawlins – PTAL

Thanks @kevmoo I still trying to figure out how this git rebase -i works. 😞

srawlins commented 1 year ago

Thanks for the rebase! 🎉

chenzhiguang commented 1 year ago

🎉