Closed chenzhiguang closed 1 year ago
How does this contain commits which are already in dart-lang:master? I can't review a PR with commits like this... but I'm honestly not even sure how it's happened. CC @kevmoo, my git expert. What is needed here? A rebase?
I did a rebase, then it messed up.
Yeah, you want to do a git rebase -i
– and squash things down
@chenzhiguang – I think I fixed it.
@srawlins – PTAL
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/src/block_syntaxes/table_syntax.dart | 1 | 89.66% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 3323865806: | 0.004% |
Covered Lines: | 1210 |
Relevant Lines: | 1274 |
@chenzhiguang – I think I fixed it.
@srawlins – PTAL
Thanks @kevmoo I still trying to figure out how this git rebase -i
works. 😞
Thanks for the rebase! 🎉
🎉
Now it is 100% conform to GFM table spec.