search

dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
443 stars 201 forks source link

Improve FencedCodeBlockSyntax #478

Closed chenzhiguang closed 1 year ago

chenzhiguang commented 1 year ago

Strictly improves the test coverage.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3416074963

Totals Coverage Status
Change from base Build 3415798023: 0.08%
Covered Lines: 1223
Relevant Lines: 1289
💛 - Coveralls
kevmoo commented 1 year ago

@chenzhiguang – please rebase on master – we now have flutter_markdown validation in place

If there are breaks there, we'll have to dig to see what's expected/intended.

chenzhiguang commented 1 year ago

Rebased

chenzhiguang commented 1 year ago

Can we have a look at this one? It is important to my next PR.

chenzhiguang commented 1 year ago

Benchmark

Before

Screenshot 2022-11-04 at 18 01 48

After

Screenshot 2022-11-04 at 18 05 01

kevmoo commented 1 year ago

@srawlins – I think benchmarks look fine, no?

chenzhiguang commented 1 year ago

rebased

srawlins commented 1 year ago

CC @devoncarew

This one passes flutter_markdown 🎉

chenzhiguang commented 1 year ago

Cool, thanks!