benchmark: use Stopwatch over DateTime for benchmarking

dart-lang / markdown

A Dart markdown library

https://pub.dev/packages/markdown

BSD 3-Clause "New" or "Revised" License

443 stars 201 forks source link

benchmark: use Stopwatch over DateTime for benchmarking #491

Closed kevmoo closed 1 year ago

kevmoo commented 1 year ago

Use built-in String.padLeft

kevmoo commented 1 year ago

Feel free to squash/merge and delete the branch if you're happy

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3464335749

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.906%

Totals
Change from base Build 3464258911:	0.0%
Covered Lines:	1211
Relevant Lines:	1276

💛 - Coveralls

kevmoo commented 1 year ago

Gah! I just benchmarked this – turns out the perf delta is trivial. I think it's better to use Stopwatch just because there is zero chance of timezone silly...but 🤷