dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
443 stars 201 forks source link

Refactor list syntax #499

Closed chenzhiguang closed 1 year ago

chenzhiguang commented 1 year ago

benchmark before

Screenshot 2022-11-30 at 05 32 28

benchmark after

Screenshot 2022-11-30 at 05 30 17

chenzhiguang commented 1 year ago

The smoke test fails. I will check that.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3585947176


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/block_syntaxes/list_syntax.dart 49 51 96.08%
<!-- Total: 88 90 97.78% -->
Totals Coverage Status
Change from base Build 3577213587: 1.04%
Covered Lines: 1279
Relevant Lines: 1337

💛 - Coveralls
kevmoo commented 1 year ago

@chenzhiguang – we'll have to do the same dance w/ flutter_markdown again. Want to send a PR there?

chenzhiguang commented 1 year ago

@chenzhiguang – we'll have to do the same dance w/ flutter_markdown again. Want to send a PR there?

PR is ready: https://github.com/flutter/packages/pull/2862

kevmoo commented 1 year ago

@srawlins – we're green on Flutter markdown!

chenzhiguang commented 1 year ago

@srawlins Hi, I am waiting for these two latest PRs get revived, so I can continue to work on other issues.

kevmoo commented 1 year ago

@srawlins has MANY responsibilities. We just need to be patient.

chenzhiguang commented 1 year ago

Thank you!