dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
443 stars 201 forks source link

Rewrite SetextHeaderSyntax #500

Closed chenzhiguang closed 1 year ago

chenzhiguang commented 1 year ago

The performance is also much better according to the new algorithm.

Benchmarks

Before

Screenshot 2022-12-01 at 06 40 02

After

Screenshot 2022-12-01 at 06 39 05

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3715434327


Files with Coverage Reduction New Missed Lines %
lib/src/block_syntaxes/table_syntax.dart 1 88.51%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 3707734073: 0.08%
Covered Lines: 1282
Relevant Lines: 1339

💛 - Coveralls
chenzhiguang commented 1 year ago

The flutter_markdown test will be green when this PR is merged: Refactor list syntax

chenzhiguang commented 1 year ago

Ready for review!

chenzhiguang commented 1 year ago

@srawlins Hi, can we continue with this one?