dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
443 stars 201 forks source link

Rewrite link reference definitions #506

Closed chenzhiguang closed 1 year ago

chenzhiguang commented 1 year ago

Now it has a clean ParagraphSyntax.

Benchmarks

Before

Screenshot 2023-01-14 at 16 35 52

After

Screenshot 2023-01-14 at 16 34 53

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3999639675


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/link_parser.dart 94 95 98.95%
<!-- Total: 123 124 99.19% -->
Files with Coverage Reduction New Missed Lines %
lib/src/block_syntaxes/paragraph_syntax.dart 2 86.67%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 3999565601: 0.3%
Covered Lines: 1374
Relevant Lines: 1431

💛 - Coveralls
chenzhiguang commented 1 year ago

@srawlins Hi Sam, please do not forget this one when you have time. And there are some more PRs after it. 🙂

kevmoo commented 1 year ago

@chenzhiguang – just updated your branch w/ my latest change

chenzhiguang commented 1 year ago

@chenzhiguang – just updated your branch w/ my latest change

Thanks. I am just about to do it.

chenzhiguang commented 1 year ago

Awesome! 🥳