dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
441 stars 201 forks source link

Table display fails if there are trailing spaces #539

Closed jgfoster closed 1 year ago

jgfoster commented 1 year ago

For example, see https://github.com/ponnamkarthik/FlutterToast/issues/435. Or try the following in https://dart-lang.github.io/markdown/.

### good

| property   | description                               | default    |  
| ---------- | ----------------------------------------- |------------|
| child      | Widget (Not Null)(required)               | required   |  

### bad

| property   | description                               | default    |  
| ---------- | ----------------------------------------- |------------|  
| child      | Widget (Not Null)(required)               | required   |  
chenzhiguang commented 1 year ago

Thanks! I can reproduce it. I will fix it asap.

jgfoster commented 1 year ago

@chenzhiguang, I'm teaching a CS class where the students are assigned to make an open source contribution but since they are early in their training they don't have a lot of programming skills yet. The assignment is focused on the Git fork/clone/edit/add/commit/push/pull-request cycle rather than the actual coding. For that reason, if the fix is relatively simple and you want to explain it and accept a PR, then I could assign a student to do it. But if you want to just fix it yourself that's completely fine as well. (In any case, the work-around is fairly trivial once we see the problem!)

chenzhiguang commented 1 year ago

@jgfoster Thank you for your interest in contributing to our project. While the issue you mentioned may be relatively simple to fix, we do think that it requires a better understanding of our project as a whole. It may be more ideal to create a dedicated project for your students to practice the Git cycle. We wish you the best of luck with your class!