search

dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
440 stars 200 forks source link

✨ Introduce AlertBlockSyntax #570

Closed AlexV525 closed 6 months ago

AlexV525 commented 7 months ago

Resolves https://github.com/dart-lang/markdown/issues/567 by implementing a new syntax similar to blockquote.

https://docs.github.com/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
AlexV525 commented 7 months ago

Let me know if I can fill in more test cases.

parlough commented 6 months ago

Thanks for working on this Alex!

\cc @srawlins @kevmoo For review since GitHub has now announced and documented this feature, likely resulting in greatly increased usage.

kevmoo commented 6 months ago

Wonderful! Please add

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7163959186

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/block_syntaxes/callout_block_syntax.dart 26 35 74.29%
<!-- Total: 27 36 75.0% -->
Totals Coverage Status
Change from base Build 7055081874: -0.5%
Covered Lines: 1538
Relevant Lines: 1604
💛 - Coveralls
AlexV525 commented 6 months ago

Wonderful! Please add

All done @kevmoo

AlexV525 commented 5 months ago

Hi @kevmoo @srawlins do we have any plan to publish a new version of the package?

srawlins commented 5 months ago

Sorry for the delay, I will prioritize publishing.