dart-lang / markdown

A Dart markdown library
https://pub.dev/packages/markdown
BSD 3-Clause "New" or "Revised" License
440 stars 200 forks source link

Fix #578: list with checkbox mixed with empty lines #583

Closed tomyeh closed 4 months ago

tomyeh commented 4 months ago

taskListItemState shall be reset before calling parseTaskListItem when detecting a list pattern. O/W, it will generate a checkbox for an empty item.


Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 7972471086

Details


Totals Coverage Status
Change from base Build 7907947836: 0.0%
Covered Lines: 1542
Relevant Lines: 1604

💛 - Coveralls