Closed mym0404 closed 3 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I renewed Google CLA. It should work now
Totals | |
---|---|
Change from base Build 8223548919: | 0.01% |
Covered Lines: | 1547 |
Relevant Lines: | 1609 |
Fix #597
By the Commonmark Spec URL-escaping should be left alone inside the destination, reimplement
normalizeLinkDestination
util function with splitting by URL Escapings and concatenating them again.We shouldn't use
decodeXXX
at initial string in any ways.This doesn't make problem with fixed issue #589. All tests previous exist also are passed.
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.