Change == null to is T to handle "double nullable" case
We use dummyValueOrNull<T>/ifNotNull combination to return a proper Future<T> when T is not known at compile time but a dummy value for T exists at run time, instead of falling back to creating a FakeFuture (that can't be awaited for example).
This works fine unless T itself allows null (is nullable or void). In this case dummyValueOrNull<T> returns null, but it's a proper T, not a failure. This CL changes ifNotNull to check is T instead of == null to handle this properly.
Change
== nulltois Tto handle "double nullable" caseWe use
dummyValueOrNull<T>/ifNotNullcombination to return a properFuture<T>whenTis not known at compile time but a dummy value forTexists at run time, instead of falling back to creating aFakeFuture(that can't beawaited for example).This works fine unless
Titself allowsnull(is nullable orvoid). In this casedummyValueOrNull<T>returnsnull, but it's a properT, not a failure. This CL changesifNotNullto checkis Tinstead of== nullto handle this properly.