search

dart-lang / native

Dart packages related to FFI and native assets bundling.
BSD 3-Clause "New" or "Revised" License
82 stars 27 forks source link

[native_assets_cli] Support adding new assets in `hook/link.dart` #1084

Open dcharkes opened 1 month ago

dcharkes commented 1 month ago

This needs to be supported downstream:

After we support adding assets in link hooks, we should update the doc comments on link.

The current workaround is to always add assets in hook/build.dart. @mosuem doesn't this workaround actually lead to duplicate assets? We would be "overriding" assets from the build hook with the link hook output. (Maybe I should prio the two above issues and the ones blocking that.)

mosuem commented 1 month ago

Adding new assets in link.dart is not a priority I would say - but it would need some checking to avoid duplicating assets, or a policy on how to resolve duplicate assets.