dart-lang / native

Dart packages related to FFI and native assets bundling.
BSD 3-Clause "New" or "Revised" License
82 stars 27 forks source link

Replace coverage.sh with a dart tool #1120

Closed liamappelbe closed 1 week ago

liamappelbe commented 1 week ago

Share code between the one in package:objective_c and the one in package:ffigen.

Also, dedupe the "Run VM tests" and "Collect coverage" steps. coverage.sh runs the tests for a second time, but due to a bug in that script they need to be run separately first, otherwise test failures are ignored.

liamappelbe commented 1 week ago

Actually, the only reason these scripts still exist is to customize the --scope-output flag. I can just add that flag to test_with_coverage, then delete these scripts: https://github.com/dart-lang/coverage/pull/488