test pkgs/native_assets_builder/test/build_runner/link_test.dart fails on MacOS

dart-lang / native

Dart packages related to FFI and native assets bundling.

BSD 3-Clause "New" or "Revised" License

157 stars 44 forks source link

test pkgs/native_assets_builder/test/build_runner/link_test.dart fails on MacOS #1381

Closed dcharkes closed 2 months ago

dcharkes commented 3 months ago

The following fixes the test suite for MacOS:

  test('treeshaking assets using CLinker',
      timeout: longTimeout,
      skip: Platform.isMacOS || Platform.isWindows, () async {

@mosuem are we not running this test suite on the CI for MacOS?

mosuem commented 3 months ago

We shouldn't run it - or what do you mean?

dcharkes commented 3 months ago

We shouldn't run it - or what do you mean?

Well the test simply fails in the link hook because it's only supported on Linux. And the test has no skip or early returns for other OSes. I don't suppose we should run it if it will simply fail?