ObjC: NSString should subclass NSObject

dart-lang / native

Dart packages related to FFI and native assets bundling.

BSD 3-Clause "New" or "Revised" License

106 stars 36 forks source link

ObjC: NSString should subclass NSObject #275

Open brianquinlan opened 2 years ago

brianquinlan commented 2 years ago

The generated code for NSString starts with:

class NSString extends _ObjCWrapper

it should be

class NSString extends NSObject

liamappelbe commented 2 years ago

Where are you seeing it extend _ObjCWrapper? In test/native_objc_test/string_bindings.dart it extends NSObject. Maybe there's specific circumstances where the bug happens?

liamappelbe commented 2 years ago

Hmmm. It looks like some of the other tests (eg method_bindings.dart) are extending _ObjCWrapper.