ASM vs Doclet backend issues

dart-lang / native

Dart packages related to FFI and native assets bundling.

BSD 3-Clause "New" or "Revised" License

112 stars 39 forks source link

Closed mahesh-hegde closed 1 year ago

mahesh-hegde commented 1 year ago

Found some bugs in asm summarizer when implementing dart-lang/native#634.

~- [ ] Wildcard type is reported as DeclaredType~ - To be implemented along with dart-lang/native#701

[x] Enum values not contained.
[x] ASM summarizer reports public static final char as int instead of String.

mahesh-hegde commented 1 year ago

Cross link dart-lang/native#701 . We can skip wildcards for now if that proves to be tedious.

HosseinYousefi commented 1 year ago

ASM summarizer reports public static final char as int instead of String.

Is that a bug or a feature?

mahesh-hegde commented 1 year ago

Doclet reports string, so since doclet is default, its a bug..

HosseinYousefi commented 1 year ago

Doclet reports string, so since doclet is default, its a bug..

I meant that I think int is correct. So whichever reports String is incorrect.