dart-lang / native

Dart packages related to FFI and native assets bundling.
BSD 3-Clause "New" or "Revised" License
117 stars 40 forks source link

package:android_jni package:java_jni repositories #734

Open dcharkes opened 1 year ago

dcharkes commented 1 year ago

https://github.com/mahesh-hegde/android_jni proof of concept using current PR dart-lang/jnigen#110

_Originally posted by @mahesh-hegde in https://github.com/dart-lang/native/issues/731

If we want to start making the generated bindings available (as very experimental) we need to solve some logistics questions.

Should package:android_jni and package:java_jni live in this repository? Or in separate ones.

Arguments for the same repository:

Arguments for a separate repositories:

package:java_jni and package:android_jni need to be different packages, because using the Android APIs on a desktop/CLI app that spawns a JVM itself, there are no Android APIs.

FYI @mit-mit

mahesh-hegde commented 1 year ago

PR Reviewing: changes in jnigen cause really huge diffs if we have them in same repo. But in case of different repo maybe we can setup a bot or something.

dcharkes commented 1 year ago

Crosslink, this is a question about the repo for:

HosseinYousefi commented 4 months ago

We probably want to do this after 1.0. I'll keep it in the backlog.