search

dart-lang / native

Dart packages related to FFI and native assets bundling.
BSD 3-Clause "New" or "Revised" License
102 stars 35 forks source link

ApiSummarizer.jar should be rebuilt when outdated #778

Closed dcharkes closed 1 year ago

dcharkes commented 1 year ago 
$ dart bin/setup.dart 
ApiSummarizer.jar exists. Skipping build..

This should probably check file timestamps or a version number, so that it can rebuild itself when a newer version of this package is fetched.

mahesh-hegde commented 1 year ago

https://github.com/dart-lang/jni_gen/blob/a067d0b1ed53acb6202f98bf5c7547cdbcf92c23/jni_gen/lib/src/tools/build_summarizer.dart#L44

dcharkes commented 1 year ago

That is surprising. I had to force it in order to make it work when I filed this bug.

mahesh-hegde commented 1 year ago

Actually user should never need to run jni_gen:setup manually. buildSummarizerIfNotExists is called in beginning of generateJniBindings().

    Mahesh

On Thu, 1 Sep, 2022, 7:37 pm Daco Harkes, @.***> wrote:

That is surprising. I had to force it in order to make it work when I filed this bug.

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/jni_gen/issues/39#issuecomment-1234332493, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALAKLFWCSIRW5PRXIL2TEWLV4C2A3ANCNFSM6AAAAAAQBFDLVU . You are receiving this because you commented.Message ID: @.***>