dart-lang / pana

Package ANAlysis for Dart
https://pub.dev/packages/pana
BSD 3-Clause "New" or "Revised" License
207 stars 44 forks source link

Pana should use --suppress-analytics instead of --no-analytics #1208

Closed sigurdm closed 1 year ago

sigurdm commented 1 year ago

The old argument was deprecated See https://github.com/dart-lang/linter/issues/4204 .

I don't know if we need to branch depending on the version of the analysing sdk?

@isoos what do you think?

isoos commented 1 year ago

I don't know if we need to branch depending on the version of the analysing sdk?

Update: I don't think we need a git branch, but we need a different logic in pana to handle different SDKs.

sigurdm commented 1 year ago

Yeah - not git branch - conditional branching :)