search

dart-lang / pana

Package ANAlysis for Dart
https://pub.dev/packages/pana
BSD 3-Clause "New" or "Revised" License
207 stars 44 forks source link

iOS/macOS packages are incorrectly labeled as SwiftPM incompatible if they don't have native code. #1419

Open sigurdm opened 1 week ago

sigurdm commented 1 week ago

For example this federated package: https://pub.dev/packages/shared_preferences/score

This package supports iOS/macOS, but all the native code is in a dependency, which does support SwiftPM: https://pub.dev/packages/shared_preferences_foundation/score

Could we update the pana tagger to flag a package as SwiftPM incompatible only if it has a /.podspec file?

For example, if the shared_preferences plugin has a ios/shared_preferences.podspec file.

stuartmorgan commented 5 days ago

Could we update the pana tagger to flag a package as SwiftPM incompatible only if it has a /.podspec file?

For example, if the shared_preferences plugin has a ios/shared_preferences.podspec file.

Capturing here in addition to the PR: the authoritative indication of whether or not there should be native code is the presence of the pluginClass key (example).